Separate go build and gofmt checks.

jish / pre-commit

A slightly improved pre-commit hook for git

https://jish.github.io/pre-commit/

Other

796 stars 96 forks source link

Closed marcosvm closed 8 years ago

marcosvm commented 10 years ago

This Pull Request separates go build and gofmt checks and creates a go group with both checks.

Some larger projects that contains packages don't behave so well with the go build check, giving false positives errors.g

\cc @jish

jish commented 10 years ago

Sorry the tests were failing :( They should be green in master now. Can you merge in master and let the tests run again?

marcosvm commented 10 years ago

It didn't work. Maybe we should pair and fix this later this week.

jish commented 10 years ago

Yea, sounds good! :)

mpapis commented 10 years ago

also this is a good thing for extraction planned in #176

mpapis commented 10 years ago

just reviewed the failing tests, the problem is not added the new checks in https://travis-ci.org/jish/pre-commit/jobs/32905698#L438:

  -Available checks   : ... go jshint ...
  +Available checks   : ... go go_build go_fmt jshint ...

not sure if anything else changed, @marcosvm it should be enough to modify files listed by:

grep -rn "go jshint" test/