search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Reek checker plugin to detect ruby code smells #164

Open leonsp opened 10 years ago

leonsp commented 10 years ago

Adds a reek check plugin. Reek is a static code analysis gem for Ruby. Unlike Rubocop, it doesn't do style, but catches several bad practices Rubocop misses.

mpapis commented 10 years ago

@jish it would be great opportunity to make use of pre-commit-plugins

jish commented 10 years ago

@leonsp this change generally looks good, could you remove the version bump, and atttempt to fix the tests.

jish commented 10 years ago

@mpapis Do you have ideas on how should it be structured?

mpapis commented 10 years ago

extracting this to separate gem is mostly creating the same files / directories as in this PR, an extra readme, gemspec and few test files would be needed

mpapis commented 10 years ago

@leonsp please have a look into https://github.com/mpapis/pre-commit-php as an example how to create external plugins

leonsp commented 10 years ago

Thanks! I will try to set up something similar (pre-commit-reek, etc).

mpapis commented 8 years ago

now on master you can:

pre-commit new plugin-name 'Author Name' author@email 'description of the plugin'

this will generate scaffold for your gem - should be easy to move it from this point on, please let me know if you find any more instructions that should be added (open a new issue).