search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Upgrade JSHint to 2.5.4 #177

Closed jish closed 10 years ago

jish commented 10 years ago

Previously we vendored + patched a copy of JSHint each time we needed to upgrade. This commit takes a plain copy of JSHint and adapts PreCommit to use JSHint out of the box.

This should make future JSHint upgrades much easier :)

@shajith @mpapis @mwerner

Closes #157

mpapis commented 10 years ago

looks good to me ;)

shajith commented 10 years ago

+1, looks legit, left some minor notes. The build's broken though?

jish commented 10 years ago

:haircut: updated with suggestions

I'm not sure what to do about the JRuby test failures. Should we drop JRuby from Travis for the time being?

shajith commented 10 years ago

+1. Maybe mark the jruby build as optional in the travis matrix? I haven't looked at the failure myself, so take that as a light suggestion.

jish commented 10 years ago

"Maybe mark the jruby build as optional in the travis matrix?"

https://github.com/jish/pre-commit/pull/178

mpapis commented 10 years ago

jruby issue https://github.com/jruby/jruby/issues/1945 - will be fixed in 1.7.16, might take some time for it to make to travis

shajith commented 10 years ago

+1