search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Unencrypted file check. #188

Closed brupm closed 8 years ago

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.36%) when pulling 5a1d43e05ce07a1dec8244b36e989aeac457b2cc on brupm:unencrypted_files into f75fe6d0c77339da4299f2f1a7149869fee6cb6f on jish:master.

mpapis commented 9 years ago

have you tried building a gem with exactly the same path? check https://github.com/pre-commit-plugins/pre-commit-php for more detailed example.

@jish what is the new policy on checks, do we merge everything or prefer gems with plugins?

brupm commented 9 years ago

@mpapis to be honest the docs on "building a gem" were a bit confusing. I forked and wrote this as a trial, didn't actually mean to try to to merge it in just yet. Feel free to close this.

mpapis commented 9 years ago

well, do not want to reject your code, was just thinking that with a gem you get 1) faster delivery 2) control over your code 3) I know the docs suck, that's why I have extracted https://github.com/pre-commit-plugins/pre-commit-php - would be great if you could help us write / improve the docs for creating a gem, a lot of the things to do is obvious to me, having problems and solving them you would be an best prepared person to write this instructions - feel free to ask questions if you need any help with it

mpapis commented 8 years ago

this should be a gem, closing this

mpapis commented 8 years ago

now on master you can:

pre-commit new plugin-name 'Author Name' author@email 'description of the plugin'

this will generate scaffold for your gem - should be easy to move it from this point on, please let me know if you find any more instructions that should be added (open a new issue).