search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Closure_linter check #200

Closed tsevan closed 9 years ago

tsevan commented 9 years ago

I suggest connecting pre-commit and closure_linter. We use their guide in our project for JS codestyle, and it would be nice to do that automatically.

This implementation requires external install of closure_linter (which is available in ubuntu in the universe repo f.e.). I put a note about this fact in README.

Thanks.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.18%) to 98.47% when pulling d0d6a08bfb6382ef1f3a755f5eb7590098ff53d1 on tsevan:closure-linter into 5a1eb5e14593b43da1cd2bfcbefff6e66d96a42e on jish:master.

mpapis commented 9 years ago

@tsevan you can convert your tool into pre-commit plugin, for an example check: https://github.com/pre-commit-plugins/pre-commit-php

tsevan commented 9 years ago

@mpapis Okay, I published there: https://github.com/tsevan/pre-commit-closure-linter. I'm also going to add a configuration opportunity soon.

mpapis commented 9 years ago

@jish 1) we could get it to https://github.com/pre-commit-plugins/ 2) if not do we keep list of all the external plugins? maybe a wiki?

jish commented 9 years ago

"1) we could get it to https://github.com/pre-commit-plugins/"

sure.

"2) if not do we keep list of all the external plugins? maybe a wiki?"

Yea, we should probably list plugins whether they live in pre-commit-plugins or not... I added a very simple page here https://github.com/jish/pre-commit/wiki/Plugins we can obviously iterate on it and clean it up.

jish commented 9 years ago

@tsevan I've created https://github.com/pre-commit-plugins/pre-commit-closure-linter and added you as a collaborator. We can move the plugin there if you like, or you can leave it under your name and delete the repo under pre-commit-plugins. Whatever works best ;)