jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Adding rspec check for focus syntactic sugar #204

Closed prpetten closed 7 years ago

prpetten commented 9 years ago

I always use the 'f' prefix for adding focus to my specs in rspec rather than :focus, so the existing check wasn't helping me. I added this to help prevent me from adding focus to my team's specs.

this commit fixes #205

jish commented 9 years ago

This looks good, thanks. I think we should combine this check with the rspec_focus check. They both do conceptually the same thing.

I can work on combining them or I can let you handle it, let me know ;)

prpetten commented 9 years ago

I'll combing them, and send it back over to you. Didn't know which would be preferred.

jish commented 7 years ago

I have some time to combine the two checks into one, so I'll merge this in.