Adding checks for byebug in same fashion as debugger

jish / pre-commit

A slightly improved pre-commit hook for git

https://jish.github.io/pre-commit/

Other

796 stars 96 forks source link

Adding checks for byebug in same fashion as debugger #207

Closed prpetten closed 9 years ago

prpetten commented 9 years ago

This pull request addresses issue #206

jish commented 9 years ago

This looks good, thanks. Do you think we should combine the debugger and byebug checks? Or would it make sense to have them separate?

cc: @shajith @mpapis

mpapis commented 9 years ago

we should merge them, it's just adding | in the regexp and updating description to say or byebug

prpetten commented 9 years ago

Sounds good, I'll merge them, just didn't know what you guys would prefer.

jclif commented 9 years ago

Any plans to merge this?

mpapis commented 9 years ago

we are still waiting for the merge of plugins ... @jclif if you are in hurry clone @prpetten repository, merge the plugins and open a new pull request

jclif commented 9 years ago

@mpapis thanks, will try that

prpetten commented 9 years ago

@jclif Let me know if you need any help. I just haven't had a chance to work on again.

jish commented 9 years ago

https://github.com/jish/pre-commit/pull/224