search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Choosing order of checks? #209

Open knovoselic opened 9 years ago

knovoselic commented 9 years ago

Is there a way to define order in which checks are executed? For example, I'd like to run to run ci check (pre_commit:ci rake task) last because it takes the longest.

mpapis commented 9 years ago

try with https://github.com/jish/pre-commit#enabling--disabling-checks--warnings

knovoselic commented 9 years ago

I'm using YAML for configuration (config/pre_commit.yml) and ci is last in checks_add array, but it still gets executed first (or at least before rubocop). Am I missing something?

mpapis commented 9 years ago

@jish it's a bug or feature request?

jish commented 9 years ago

I guess we've always just hard coded an order in the past.

I'm ok with changing the order for everyone and / or making the order configurable.

Josh

On Apr 2, 2015, at 04:58, Michal Papis notifications@github.com wrote:

@jish it's a bug or feature request?

— Reply to this email directly or view it on GitHub.