search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Add pry-remote/pry-remote-em to Pry checks #212

Closed m1foley closed 8 years ago

m1foley commented 9 years ago

pry-remote/pry-remote-em are common plugins for Pry.

https://github.com/pry/pry/wiki/Available-plugins

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 98.65% when pulling 446486ccae3777fbe7590cc1efe2e756e5639d9c on m1foley:pry-remote into 5c6f62aa709b9396f221cd49e96863ee4c6e0ee7 on jish:master.

mpapis commented 9 years ago

:+1:

jish commented 9 years ago

Hmm... the tests seem to be failing. Once we get those sorted out, this looks fine.

mpapis commented 8 years ago

now on master you can:

pre-commit new plugin-name 'Author Name' author@email 'description of the plugin'

this will generate scaffold for your gem - should be easy to move it from this point on, please let me know if you find any more instructions that should be added (open a new issue).

m1foley commented 8 years ago

I believe this change is to granular to be made a separate pry-remote plugin; it should modify the existing pry check. Do you disagree?

mpapis commented 8 years ago

ah right, sorry, I was not looking deep enough before posting my comment

m1foley commented 8 years ago

Just rebased off master. Travis still says it's failing because tests are broken on master.

mpapis commented 8 years ago

master is green: https://travis-ci.org/jish/pre-commit/builds/107029409

the failure happens in case of jruby here: https://travis-ci.org/jish/pre-commit/jobs/110663827#L428 - it looks like parsing of the output is wrong, it does not split on new lines

m1foley commented 8 years ago

You're right, I needed to update the test.

I was thrown off because bundle exec rake produces 6 failures for me locally on master.

mpapis commented 8 years ago

LGTM

jish commented 8 years ago

Thanks for your contribution!