jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Move all development dependencies into one place. #226

Closed jish closed 9 years ago

jish commented 9 years ago

I'm not sure whether .gemspec is better, or Gemfile is better. We're using Bundler's platform options like :platforms => [:mri_20] so I'm moving them all into Gemfile. If that is not correct, we can change it.

mpapis commented 9 years ago

hmm, this is hard question, .gemspec is parsed for dependencies and they are posted on rubygems - so it all depends if we want to list those dependencies as a requirement for development or not?

jish commented 9 years ago

Yea, I'm ok with either, I just thought it would be nice to have them all in one place (rather than two different places).