search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Upgrade to jshint 2.9.0 #227

Closed danielstjules closed 8 years ago

danielstjules commented 8 years ago

Hey Josh! Wondering if we could upgrade jshint?

$  md5 jshint/dist/jshint.js pre-commit/lib/pre-commit/support/jshint/jshint.js
MD5 (jshint/dist/jshint.js) = 07ce0b366367159e177ae13feefc3abf
MD5 (pre-commit/lib/pre-commit/support/jshint/jshint.js) = 07ce0b366367159e177ae13feefc3abf

Feel free to close this if you'd like to do it yourself :)

jish commented 8 years ago

I'm all for updating JSHint or even detecting what version is installed locally in the current repo.

Unfortunately, it looks like the tests are failing :( I think @shajith wrote some JavaScript-fu to make JSHint play nicely with ExecJS. @shajith ?

danielstjules commented 8 years ago

I'm all for updating JSHint or even detecting what version is installed locally in the current repo.

I like this idea better :) Happy to close this and come up with a different solution