search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Remove closure check #228

Closed jish closed 8 years ago

mpapis commented 8 years ago

what are the reasons to remove it? are we extracting it to separate gem?

jish commented 8 years ago

After upgrading to El Capitan, there is a Java error when running the closure check.

The closure check was one of the first checks added, and the purpose was to sanity check JavaScript code. I think the community has moved towards JSLint / JSHint (and more recently even ESHint). So, I don't think we really need to support this anymore.

Of course, we can always provide this as a plugin under pre-commit-plugins if necessary :)

mpapis commented 8 years ago

now this makes sense, I thought we are removing support for checking closure syntax, if it's just another tool for JS syntax - please get rid of it

LGTM