search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

add cli new #233

Closed mpapis closed 8 years ago

mpapis commented 8 years ago 
Usage: pre-commit new plugin-name 'Author Name' author@email 'description of the plugin'

@jish I hope you like it :) is there anything I could do better (except adding tests)?

jish commented 8 years ago

looks good if we can get tests passing.

mpapis commented 8 years ago

applied suggestions and tests are passing

mpapis commented 8 years ago

here is the extracted tool: https://github.com/mpapis/tree_renderer - @jish should I open new PR making use of it or you are fine with current implementation?

jish commented 8 years ago

I think the current implementation is ok.

Good job extracting the functionality :) In this case I think it is small enough that it does not warrant adding a new gem dependency.

Josh

On Feb 11, 2016, at 01:26, Michal Papis notifications@github.com wrote:

here is the extracted tool: https://github.com/mpapis/tree_renderer - @jish should I open new PR making use of it or you are fine with current implementation?

— Reply to this email directly or view it on GitHub.