search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Added a short circuit check #237

Open ideasasylum opened 8 years ago

ideasasylum commented 8 years ago

I'm not sure if this is generally useful but I've found it very important. This checks for accidental short-circuits often used in debugging, e.g. Rails views, to force a particular state.

Statements like,

if true || something
if false && something

can be used when developing to force a particular condition but they're almost certainly an error if committed to Git.

I based this check & tests on the debugger check so I hope I haven't missed anything.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.03%) to 96.279% when pulling 4fe1a95a933c3ebe0808e70d05cec545400c95b7 on ideasasylum:master into 860ce02ce2a1c3523e14297682a06f1402292c18 on jish:master.

mpapis commented 8 years ago

oh, I missed to update readme, there is now easy way to create external plugins => https://github.com/jish/pre-commit/blob/master/lib/pre-commit/cli.rb#L31 - maybe try to make it an external plugin and we can add it to https://github.com/pre-commit-plugins/ and list it in the readme :)

code itself LGTM

dannysmith commented 6 years ago

@ideasasylum Did you ever make a plugin out of this?