search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Add missing require plugin line in go_fmt plugin #261

Closed mpapis closed 7 years ago

mpapis commented 7 years ago

Problem was found in #258, but not related to the issue - @jonatanklosko this should fix your problem

I used:

puts Dir["lib/plugins/pre_commit/checks/**/*.rb"].map{|n| 
  n unless File.readlines(n).any?{|l| l=~%r{pre-commit/checks/} } 
}.compact

to confirm it's the only file that missed the require.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.002%) to 97.265% when pulling 185ffa4e5db1334fd03aa9b84c699a6cb5ee83e8 on bugfix/add-missing-require-plugin-to-go_fmt into d7f55e658b60819ee4e394e150a84f7d44d36471 on master.

jonatanklosko commented 7 years ago

This makes sense, thanks!

jish commented 7 years ago

Thanks @mpapis!

jish commented 7 years ago

Published version 0.35.0 https://rubygems.org/gems/pre-commit

jonatanklosko commented 7 years ago

Finally everything works, thanks a lot guys =)