jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Upgrade minitest and minitest-reporters #271

Closed jish closed 6 years ago

jish commented 6 years ago

The jruby builds were failing to find a module inside of the minitest-reporters gem. It was using an old, outdated version of minitest-reporters due to our version specification of ~> 0.

Upgraded minitest-reporters to ~> 1.

That required an update of minitest to ~> 5. The minitest 5 upgrade brought on some deprecation warnings that we needed to clean up. We can no longer use must_equal with nil as an argument, it must be changed to must_be_nil.

cc: @shuheiktgw

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 97.329% when pulling 52af4a70aad642ea52f45703673e52a1c853f8b8 on minitest5 into b3a653eb063d890dd7277265746da4da6a8d47ab on master.