search

jish / pre-commit

A slightly improved pre-commit hook for git
https://jish.github.io/pre-commit/
Other
796 stars 96 forks source link

Drop Ruby 2.0 from Travis builds #272

Closed jish closed 6 years ago

jish commented 6 years ago

RuboCop will no longer install on Ruby 2.0, and Ruby is on the 2.5.x branch now.

cc: @shuheiktgw

jish commented 6 years ago

"should we add the new rubies to test on?"

Yes! 🙂

2.5.1 was added here: https://github.com/jish/pre-commit/pull/270

But I think Travis supports just using two-digit version numbers, https://docs.travis-ci.com/user/languages/ruby/, so I think we should probably have 2.1, 2.2, 2.3, 2.4, 2.5? 🤔

jish commented 6 years ago

"I think we should probably have 2.1, 2.2, 2.3, 2.4, 2.5? 🤔"

I guess not. Travis is using outdated patch levels when only using two digits for the version number 😞

2.3 is mapping to to 2.3.4 instead of 2.3.7 https://travis-ci.org/jish/pre-commit/jobs/393411030#L574 and 2.4 is mapping to 2.4.1 instead of 2.4.4 https://travis-ci.org/jish/pre-commit/jobs/393411031#L574