Open NielsRogge opened 2 months ago
Hi,
Niels here from the open-source team at Hugging Face. I discovered your work through the paper page: https://huggingface.co/papers/2408.16532 (featured in daily papers). Congrats on this work!
Great to see you're making the models available on the 🤗 hub. Some small suggestions on how to improve this:
- usually we recommend to push each checkpoint to a separate model repository, so in this case, we could have "novateur/wavtokenizer-small-320" and "novateur/wavtokenizer-small-600" repos. This ensures download stats work for your models (assuming you also push a config.yaml to each model repo).
- great to see you've added the "text-to-speech" tag, just wondering whether "audio-feature-extraction" would be more appropriate? cc @Vaibhavs10
- I see you've implemented a
from_pretrained
method yourself, great! Note that we now also have the PyTorchModelHubMixin class which implements this logic (along with more, likepush_to_hub
and safetensors serialization). Happy to send a PR.Let me know if you need any help regarding this!
Cheers,
Niels ML Engineer @ HF 🤗
We appreciate the attention from the Hugging Face official team ❤!
Best regards!
Hi,
Niels here from the open-source team at Hugging Face. I discovered your work through the paper page: https://huggingface.co/papers/2408.16532 (featured in daily papers). Congrats on this work!
Great to see you're making the models available on the 🤗 hub. Some small suggestions on how to improve this:
from_pretrained
method yourself, great! Note that we now also have the PyTorchModelHubMixin class which implements this logic (along with more, likepush_to_hub
and safetensors serialization). Happy to send a PR.Let me know if you need any help regarding this!
Cheers,
Niels ML Engineer @ HF 🤗