players with fixed volumes will not receive a volume change

jishi / node-sonos-discovery

Simplified framework for Sonos built on node.js

MIT License

146 stars 75 forks source link

players with fixed volumes will not receive a volume change #57

Closed tomkxy closed 8 years ago

tomkxy commented 8 years ago

This should fix issue #150 in node-sones-http-api. I made the changes to the file sonos.js which was installed through node-sonos-http-api. It seems that they are not fully in sync.

jishi commented 8 years ago

Thanks for this. I moved the check into the setVolume call instead, that should fix both those cases that you added a check for. Let me know if it fixes your issue.

tomkxy commented 8 years ago

Hi Jimmy,

I just installed it and did a quick test. It works. I closed the issue.

Thanks a lot!

Great work!

Cheers, Thomas

Am 28.03.2016 um 20:55 schrieb Jimmy Shimizu notifications@github.com:

Closed #57 https://github.com/jishi/node-sonos-discovery/pull/57.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/jishi/node-sonos-discovery/pull/57#event-605599922