search

jishi / node-sonos-discovery

Simplified framework for Sonos built on node.js
MIT License
146 stars 75 forks source link

Support Google Play Music (I'm feeling Lucky mix) #76

Closed neophob closed 8 years ago

neophob commented 8 years ago

When the Google Play Music "I'm feeling Lucky mix" is selected in Sonos, this (streaming) mode is not detected by Sonos discovery. This URI looks like:

"uri": "x-sonosprog-http:_dklxfo-EJNFGf4fhhl5zLwSxbZ-NIJgqG7UK83SzxsF8y9ZJwK58ehTTw3hKlMO.mp3?sid=151&flags=8192&sn=8",

I guess "x-sonosprog-http" needs to be added to the getUriType.js / isRadio check, right?

jishi commented 8 years ago

Hi, this is already checked in the http api (atleast in beta https://github.com/jishi/node-sonos-http-api/blob/beta/lib/helpers/is-radio-or-line-in.js) as well as in the master branch of discovery https://github.com/jishi/node-sonos-discovery/blob/master/lib/prototypes/Player/getUriType.js

The track type is however not released yet, it was added this week. But you guys are still using the old version of http-api, correct?

neophob commented 8 years ago

Oh great, I missed that. Yes we currently use the legacy version - I updated this code in my branch. thanks