jishi / node-sonos-discovery

Simplified framework for Sonos built on node.js
MIT License
146 stars 75 forks source link

preventing infinite loop #84

Closed ColdFireIce closed 8 years ago

ColdFireIce commented 8 years ago

if browse returns something unexpected it causes an infinite loop

jishi commented 8 years ago

Have you seen this happen? Should probably throw an error instead, to prevent incomplete results.

ColdFireIce commented 8 years ago

Yeah i had that happend during testing the browse function and I think it won't hurt to have this check.

jishi commented 8 years ago

Could you update this branch and also reject with an Error object instead of a string?