Add ability to play an album by a given artist from the library

ppitkin commented 8 years ago

At the moment you can request that: 1) tracks by a specific artist are selected and played from the sonos library 2) that the tracks from an album(s) with a specific name are played from the sonos library

What is missing is the ability to play just the tracks from a specific artist from an album.

This will get around the problem of the album name not being unique. e.g. in my library I have a number of Albums titled "Gold" and currently the interface will queue up all the track from all those albums called "Gold" (and queue them in a random order).

With this request I would like to be able to request 'play the album "xxx" by artist "yyy" ' which should then cause the tracks to be queued up based on the track number on the album and will ensure I get the actual album that I'm looking for.

thanks Peter

jplourde5 commented 8 years ago

Enhancement made and proposed. Also requires acceptance of an enhancement made to sones-discovery that adds the artist name to the container search results.

jishi commented 8 years ago

I have merged the changes now. Please evaluate it. I moved the library.json to the cache folder instead, seemed more appropriate.

jplourde5 commented 8 years ago

I'll pull it down now and test it.

jplourde5 commented 8 years ago

Getting a new error on startup. Looks like you have created a setting.js to load the settings.json file.

Not seeing the settings.json file. Where does it go now?
I don't see the cache folder getting created
It is complaining that logger is not installed

I'm going to do some further digging...

jishi commented 8 years ago

settings.json goes into the same place as before, the root of sonos-http-api. The settings.js is just to consolidate settings loading and initialization.

Where do you expect the cache folder to be created? It is created in the root folder, same level as server.js.

jishi commented 8 years ago

I pushed a fix for the logger error, it only occured if you didn't have a settings.json.

jplourde5 commented 8 years ago

It found the settings.json file. Ignore. The cache folder did not get created because of the logger exception. Ignore.

The pandora section of my settings file is choking the merge. Did the settings.json structure change?

Still digging.

jplourde5 commented 8 years ago

This is the error that is getting thrown:

TypeError: Cannot set property 'username' of undefined

This is my settings.json file

{
  "pandora": {
    "username": "xxxxxx@gmail.com",
    "password": "xxxxxxxxx"
  },
  "voicerss": "0f1fa2acxxxxxxxxxxxxxxxxxxxxxx"
}

jplourde5 commented 8 years ago

Found and fixed three bugs, two in settings.js and one in spotify.js

Everything seems to work with the fixes in place

jishi commented 8 years ago

Yeah, missed a discrepancy between Node 6 and 4, node 6 no longer requires 'use strict' it seems, it is implicitly strict. Should really get some tests up and running for the http-api to avoid these kind of mistakes in the future.

jplourde5 commented 8 years ago

This enhancement is in place

ppitkin commented 8 years ago

Sorry one further test…

“/patio/musicsearch/library/album/Chris Rea+Gold” - NOTE: no “+” sign between “Chris” and “Rea” (unlike the examples given in the help file on github. )

This returned all the tracks from the album “God’s great banana skin” by “Chris Rea”

“/patio/musicsearch/library/album/Chris+Rea+Gold” - gave no matches found

“/patio/musicsearch/library/album/Chris Rea Gold” - gave no matches found

“/patio/musicsearch/library/album/Chris Rea” - returned all the tracks form the album “Dancing with Strangers”

Tests with reversing the album and artist order also caused a no matches found.

From: Peter Pitkin [mailto:ppitkin@web.de] Sent: Friday, October 21, 2016 10:51 To: 'jishi/node-sonos-http-api'; 'jishi/node-sonos-http-api' Cc: 'Author' Subject: RE: [jishi/node-sonos-http-api] Add ability to play an album by a given artist from the library (#351)

Guy’s first of all my thanks again for doing all this work and the fast turnaround on issues.

So here is a summary of my experiences with the latest build (downloaded this morning – European Time)…

1) Renamed my old api directory

2) Did a git clone to get latest release

3) Did npm install – production – everything went through OK with no issues

4) Copied my settings.json file across from my old install

5) Copied my preset file (test.json) into preset directory whilst at the same time removing the default one.

6) Copied my cached “Say” command files to the /static/tts directory

7) Added the ‘ use strict’ to Spotify.js

8) Started the server.js (npm start)

9) From a web browser on my windows machine issued a “say” command to the “patio” speaker to test it was working – This worked fine J

10) From a web browser on my windows machine issed a “/patio/musicsearch/library/load” command to load the music library – this ran through but after getting the Albums it hung the Pi for about 20 mins!!! After it came back it issued the “Killed” command again and stopped the API - L

11) It had created a 16 MB libray.json file in the /cache directory. (much smaller than before)

12) Tried to restart the API and it failed until I deleted the library.json file - L

13) Tried the same test again. Same result – but this time didn’t lock the Pi. Crashed (killed) immediately after creating the library.json file. (this time the file was 23.8 MB)

14) Tried to start the API again – again wouldn’t stay up unless I deleted the library.json file.

15) Tested again – but this time with a different player used on the load command “/kitchen/musicsearch/library/load” (both kitchen and patio are PLAY:1 devices)

16) Did get multiple “resubscribe” message due to a “socket hangup” part way through the scan but didn’t seem to affect anything.

17) Just as a side note the CPU load increases steadily as the scan progresses – not sure why it should do that

18) Died again! So the command that worked yesterday and managed to get a full load without crashing didn’t work this morning. (library.json file was 15.9 MB this time)

19) Used nvm to install node version 5.3 to see if it might be a problem using 6.9.1. Same issue.

20) Tried rebooting. Using node 6.9.1 again and the Living room speaker (Play:5) – This Time It WORKED!!!!!. Library.json file 55.4MB

21) So now try to play the album “Collected” by “10cc” – “/patio/musicsearch/library/album/10cc+Collected “ gives a “no matches were found” error.

22) Try with just the album “/patio/musicsearch/library/album/Collected “ loaded the songs from 10cc and Gerry Rafferty (as the both have an album called “Collected”.)

23) Tried “/patio/musicsearch/library/album/Scorpions+Gold “ this loaded the queue with the tracks from Chris Rea and the Scorpions (both have an album called gold).

So definitely not working correctly – at least on my system

Any suggestions for further tests?

Peter

From: jplourde5 [mailto:notifications@github.com] Sent: Friday, October 21, 2016 0:54 To: jishi/node-sonos-http-api Cc: Peter; Author Subject: Re: [jishi/node-sonos-http-api] Add ability to play an album by a given artist from the library (#351)

Found and fixed three bugs, two in settings.js and one in spotify.js

Everything seems to work with the fixes in place

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jishi/node-sonos-http-api/issues/351#issuecomment-255250106 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKyrHBZ2VzOi1JSKHa1zo9xMuNv07g8rks5q1_DrgaJpZM4KcZlg . https://github.com/notifications/beacon/AKyrHMtSRwLtfYU506e4a59-njN1Lpukks5q1_DrgaJpZM4KcZlg.gif