search

jishnu28 / pe

0 stars 0 forks source link

INTERVIEW DATETIME not checked in all cases #7

Open jishnu28 opened 1 year ago

jishnu28 commented 1 year ago

Caution: INTERVIEW DATETIME cannot be earlier than current time and application date time when you advance an applicant!

This is checked when the advance command is used but subsequently, user is able to edit the INTERVIEW DATETIME to be earlier than the current time which nullifies the point of checking validity in the first place.

nus-pe-bot commented 1 year ago

Team's Response

We allowed this as the hiring manager could potentially key in a wrong datetime previously and this allows them to rectify their error.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I get the point on allowing the user to correct an error, but if they can create another error in the process of correcting one, that doesn't really make sense.

I think the crux of the issue is that the user should not be allowed to set an interview date time to be earlier than current time and application date time, whether they're adding a new applicant or editing an old applicant's details.