search

jishnujayakumar / MV-Tractus

A simple tool to extract motion vectors from h264 encoded videos.
108 stars 27 forks source link

Avoid all that library source #14

Closed adrianmay closed 4 years ago

adrianmay commented 4 years ago

Hi Jishnu,

I made a clone of your project (at least the two C targets, I don't do python) here: https://github.com/adrianmay/jishmo demonstrating how to use CMake to make it really easy to link to standard libraries installed on your machine instead of pulling in all that source code. The commit history is intended to be instructive.

It means you have to keep up with changes to the libs (especially opencv who seem to move the furniture around every day just for the hell of it) but who wants to live in suspended animation? Right now the _with_frames target has a couple of deprecated functions in. I looked into fixing them but then my breakfast appeared and I don't really need that target for my purposes (spotting intruders on my cctv) anyway.

Hope that's helpful, Adrian.

jishnujayakumar commented 4 years ago

Can you give a PR with the suggested changes? Liked the name though 😊.

adrianmay commented 4 years ago

If you take a look you'll see that it's not just a point and click thing.

On Mon, 1 Jun 2020, 18:12 Jishnu P, notifications@github.com wrote:

Can you give a PR with the suggested changes?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jishnujayakumar/MV-Tractus/issues/14#issuecomment-636993637, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAARMRZUR6D656N6Z3AYUVLRUPORJANCNFSM4NPCXQTA .

I appreciate your thoughts. I had made this repo public to make it more robust with the help of the open source community. CMAKE has always been on my To-Do but due to the unavailability of time, I gets delayed everytime. I know it's not a straightforward thing that's why it will take time and it would be great if you can help by issuing a PR since you have a better grasp over the problem. A small request. Next time onwards, please make the comments more comprehensive.