jisotalo / ads-client

Unofficial Node.js ADS library for connecting to Beckhoff TwinCAT automation systems using ADS protocol.
https://jisotalo.fi/ads-client/
MIT License
80 stars 17 forks source link

Correct typo "Susped" in `ADS_STATE` #119

Closed crishoj closed 4 months ago

crishoj commented 1 year ago

In case users rely on adsStateStr being reported as Susped, this would be a breaking change.

If you deem it's not worthwhile to correct the typo, feel free to close the pull request.

jisotalo commented 1 year ago

Thanks!

I will merge this later. Definetely the typos should be fixed.

jisotalo commented 4 months ago

@crishoj if you want, please make a similal pull request for v2 so your name will be in contributors :)

It's in ads-commons.ts

jisotalo commented 4 months ago

I'm closing this as I think I won't fix this in v1 at all.