Hopperpop
commented
3 years ago First of all, Thank you for doing this.
I tried the following test connecting to a local system:
[{"id":"6212431e.a41d64","type":"inject","z":"89b5ac23.d7af08","name":"","topic":"Drives.fbDriveCyl[1].xCylinder","payload":"","payloadType":"str","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":190,"y":100,"wires":[["9a298bb3.de0f4"]]},{"id":"87222730.0c9b","type":"debug","z":"89b5ac23.d7af08","name":"","active":true,"tosidebar":true,"console":false,"tostatus":true,"complete":"payload","targetType":"msg","x":970,"y":160,"wires":[]},{"id":"abb795ff.ad186","type":"catch","z":"89b5ac23.d7af08","name":"","scope":["dfeb82c6.20ce48","f668e8e3.d1cf78","f325de49.8f78d8"],"uncaught":false,"x":1190,"y":160,"wires":[["bbaf7fd5.4347e"]]},{"id":"6766bb6.3a67244","type":"complete","z":"89b5ac23.d7af08","name":"","scope":["dfeb82c6.20ce48","f668e8e3.d1cf78","f325de49.8f78d8"],"uncaught":false,"x":1170,"y":100,"wires":[["5d0069de.c89688"]]},{"id":"5d0069de.c89688","type":"debug","z":"89b5ac23.d7af08","name":"","active":true,"tosidebar":false,"console":false,"tostatus":true,"complete":"topic","targetType":"msg","x":1360,"y":100,"wires":[]},{"id":"bbaf7fd5.4347e","type":"debug","z":"89b5ac23.d7af08","name":"","active":true,"tosidebar":false,"console":false,"tostatus":true,"complete":"topic","targetType":"msg","x":1360,"y":160,"wires":[]},{"id":"dfeb82c6.20ce48","type":"ads-client-read-symbol","z":"89b5ac23.d7af08","connection":"1086b6ee.1f2791","variableName":"","x":670,"y":100,"wires":[["87222730.0c9b","c8d76dd2.66466","9f533d61.166d7","f8fcaf41.973b18"]]},{"id":"f668e8e3.d1cf78","type":"ads-client-write-symbol","z":"89b5ac23.d7af08","connection":"1086b6ee.1f2791","variableName":"","autoFill":false,"x":1110,"y":240,"wires":[[]]},{"id":"c8d76dd2.66466","type":"function","z":"89b5ac23.d7af08","name":"Flip","func":"msg.payload = !msg.payload;\nreturn msg;","outputs":1,"noerr":0,"x":910,"y":240,"wires":[["f668e8e3.d1cf78"]]},{"id":"9a298bb3.de0f4","type":"change","z":"89b5ac23.d7af08","name":"Add msg.test","rules":[{"t":"set","p":"test","pt":"msg","to":"Abcd","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":430,"y":100,"wires":[["dfeb82c6.20ce48"]]},{"id":"9f533d61.166d7","type":"debug","z":"89b5ac23.d7af08","name":"","active":true,"tosidebar":false,"console":false,"tostatus":true,"complete":"test","targetType":"msg","x":960,"y":100,"wires":[]},{"id":"f8fcaf41.973b18","type":"function","z":"89b5ac23.d7af08","name":"Flip","func":"msg.payload = !msg.payload;\nreturn msg;","outputs":1,"noerr":0,"x":912,"y":298,"wires":[["2d295060.2beec8"]]},{"id":"2d295060.2beec8","type":"change","z":"89b5ac23.d7af08","name":"","rules":[{"t":"set","p":"topic","pt":"msg","to":"Drives.fbDriveCyl[1].xCylinder","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":1052,"y":298,"wires":[["f325de49.8f78d8"]]},{"id":"f325de49.8f78d8","type":"ads-client-write-symbol","z":"89b5ac23.d7af08","connection":"1086b6ee.1f2791","variableName":"","autoFill":false,"x":1272,"y":298,"wires":[["b80fb4f1.d3666"]]},{"id":"b80fb4f1.d3666","type":"debug","z":"89b5ac23.d7af08","name":"","active":true,"tosidebar":true,"console":false,"tostatus":true,"complete":"topic","targetType":"msg","x":1480,"y":300,"wires":[]},{"id":"2f423273.b4d08e","type":"status","z":"89b5ac23.d7af08","name":"","scope":["dfeb82c6.20ce48","f668e8e3.d1cf78","f325de49.8f78d8"],"x":1180,"y":40,"wires":[["3137dd4.2419122"]]},{"id":"3137dd4.2419122","type":"debug","z":"89b5ac23.d7af08","name":"","active":true,"tosidebar":true,"console":false,"tostatus":true,"complete":"status.text","targetType":"msg","x":1380,"y":40,"wires":[]},{"id":"1086b6ee.1f2791","type":"ads-client-connection","z":"","targetAmsNetId":"localhost","targetAdsPort":"851","objectifyEnumerations":true,"convertDatesToJavascript":true,"readAndCacheSymbols":false,"readAndCacheDataTypes":false,"disableSymbolVersionMonitoring":false,"routerTcpPort":"","routerAddress":"","localAddress":"","localTcpPort":"","localAmsNetId":"","localAdsPort":"","timeoutDelay":"","hideConsoleWarnings":false,"autoReconnect":true,"reconnectInterval":"","checkStateInterval":"","connectionDownDelay":"","allowHalfOpen":false,"disableBigInt":false}]This are my current comments:
- The read/write nodes clear the full message. As far as I know most nodes just copy the full message and modifies what they are interacting on. Example: if you set "msg.topic", it would be handy if you could reuse it in later nodes.
- It can be useful if errors can be caught. See: https://nodered.org/docs/creating-nodes/node-js#handling-errors
- This comment is more about aesthetics: Having the full error message in the status can be "annoying". I can't remember if any other node does it like this. Having a short status message and having the error in the console + catch node seems better to me. (But it's just my opinion, maybe other people thing differently.)
- Being able to name the node for easy reading.
hbTecAG
jisotalo
If you have any comments please add them here. I'm not sure if everything is done correctly (how things usually are done with Node-RED).
If you find bugs and other problems, please submit a new issue.
The library now has three nodes: Read Symbol, Write Symbol and Subscribe. Each one has it's own help inside the Node-RED so check it out.