jitbit / AspNetSaml

Very simple SAML 2.0 consumer module for ASP.NET/C#
https://www.jitbit.com
Apache License 2.0
361 stars 118 forks source link

Certificate parsing of 'StringFromByteArray' is incorrect #60

Closed admalledd closed 2 years ago

admalledd commented 2 years ago

per https://github.com/dotnet/runtime/issues/47005

Using Convert.FromBase64() instead of the method in StringFromByteArray

alex-jitbit commented 2 years ago

The problem is, certificate strings start with ---BEGIN CERTIFICATE--- which is not Base64, so it will throw errors

alex-jitbit commented 2 years ago

The issue mentioned provides a certificate in a different format that's the reason it does not work