search

jithurjacob / Windows-10-Toast-Notifications

Python library to display Windows 10 Toast Notifications
MIT License
970 stars 168 forks source link

importing ToastNotifier from __main__ is very weird #5

Closed eric-wieser closed 7 years ago

eric-wieser commented 7 years ago

Would be much better to have this class either in __init__.py or its own file

This is especially weird because __name__ is either __main__ or win10toast.__main__

jithurjacob commented 7 years ago

I'm sorry but I didn't understand this. Could you please explain?

eric-wieser commented 7 years ago

Move ToastNotifier into __init__.py. It has no place in __main__.py.

You should never see the import keyword and __main__ on the same line

jithurjacob commented 7 years ago

Thank you for your help fixed the issue