search

jithware / brethap

https://jithware.github.io/brethap
GNU General Public License v3.0
50 stars 11 forks source link

New permission added with update #38

Closed jithware closed 2 years ago

jithware commented 2 years ago

For some reason view network connections permission was added with #34 update. Need to investigate if this is coming from the just_audio package

Other view network connections control vibration

jithware commented 2 years ago

According to the docs, ACCESS_NETWORK_STATE is defined for viewing network connections. Running:

grep -R ACCESS_NETWORK_STATE -A3 .
--
./build/app/outputs/logs/manifest-merger-release-report.txt:uses-permission#android.permission.ACCESS_NETWORK_STATE
./build/app/outputs/logs/manifest-merger-release-report.txt-ADDED from [com.google.android.exoplayer:exoplayer-core:2.15.0] .../.gradle/caches/transforms-2/files-2.1/2f681db8128542500b825444bc09e386/jetified-exoplayer-core-2.15.0/AndroidManifest.xml:24:5-79
./build/app/outputs/logs/manifest-merger-release-report.txt-MERGED from [com.google.android.exoplayer:exoplayer-common:2.15.0] .../.gradle/caches/transforms-2/files-2.1/ddc633bf2ebc8c7582b0768f902d2a8f/jetified-exoplayer-common-2.15.0/AndroidManifest.xml:24:5-79

--

Looks like it is merged into the brethap manifest from the package jetified-exoplayer-common-2.15.0. Which is a dependency of just_audio.

Options are

jithware commented 2 years ago

Tried a couple other packages (assets_audio_player, audioplayers) that either have similar dependencies and/or build errors/warnings. Will have to live with the new permission. The audio feature is really nice to have and is worth the added permission. The permission may dissuade some users however the reasoning is documented here.