search

jithware / brethap

https://jithware.github.io/brethap
GNU General Public License v3.0
47 stars 10 forks source link

[Feature Request]: Add monochrome icon #96

Closed xmha97 closed 1 year ago

xmha97 commented 1 year ago

Please support the Android 13 "Themed App Icons" feature.

Screenshot_2023-04-14-07-52-45-256_de.mm20.launcher2.release.jpg

jithware commented 1 year ago

See also: https://github.com/fluttercommunity/flutter_launcher_icons/issues/419

xmha97 commented 1 year ago

I think it's possible. Aves is a Flutter app and has the monochrome icon.

jithware commented 1 year ago

Brethap currently uses flutter_launcher_icons to generate app icons. At the moment it doesn't support generating monochrome icons (see https://github.com/fluttercommunity/flutter_launcher_icons/issues/419). I'll look into manually adding them. It would be preferable to use flutter_launcher_icons in the future.

jithware commented 1 year ago

@xmha97 I found this article to manually add them: add-android-themed-icon-support-to-your-flutter-app. It doesn't look to bad. Do you want to implement it and submit a pull request?

xmha97 commented 1 year ago

@xmha97 I found this article to manually add them: add-android-themed-icon-support-to-your-flutter-app. It doesn't look to bad. Do you want to implement it and submit a pull request?

Sorry, I'm not a programmer.

jithware commented 1 year ago

Your profile says you have skills in c# and you love coding for fun. This update would just be adding the images and editing xml. I can update your pull request if there are any problems.

xmha97 commented 1 year ago

Your profile says you have skills in c# and you love coding for fun.

:)))

This update would just be adding the images and editing xml. I can update your pull request if there are any problems.

OK, please check this PR: https://github.com/jithware/brethap/pull/97

jithware commented 1 year ago

Tried running the pull request on an emulator with API 33 and getting:

AAPT: error: resource drawable/ic_launcher_background (aka com.jithware.brethap:drawable/ic_launcher_background) not found.

I'll have to look a little deeper into adding monochrome.

jithware commented 1 year ago

I believe I got it working. The "B" is a little bigger now due to clipping of adaptive icons, but seems to work:

snapshot1 snapshot2

jithware commented 1 year ago

@xmha97 any chance you are fluent in the native langauge of Iran? If so, are you interested in adding it to Brethap? This way Brethap can be added to the Play Store for Iran. Here's a howto if you are interested.

jithware commented 1 year ago

In release >= 1.7.16+104

xmha97 commented 1 year ago

Thanks 🙏