Vault: Fix accounting bug for the Vault::withdrawable_reserve_amount - Githubissues

jito-foundation / restaking

https://docs.restaking.jito.network/

Other

54 stars 5 forks source link

Vault: Fix accounting bug for the Vault::withdrawable_reserve_amount #24

Closed buffalu closed 1 month ago

buffalu commented 2 months ago

Given:

There is a withdraw ticket created with funds cooling down for withdraw. Let's say the ratio is 1:1, so 1000 VRTs were deposited and 1000 collateral tokens were set aside.

When:

There is a slashing event of 100 tokens while the funds are maturing in the VaultDelegationList.

Then:

There will be 900 total tokens set aside for the withdrawal reserve in the vault, but the withdrawal ticket has 1000. When burning the withdraw ticket, there will be an underflow and the program is stuck.