jito-foundation / restaking

https://docs.restaking.jito.network/
Other
54 stars 5 forks source link

Vault: Implement CreateTokenMetadata #32

Closed aoikurokawa closed 2 months ago

aoikurokawa commented 2 months ago

Motivation

Solution

aoikurokawa commented 2 months ago

Hi @buffalu @coachchucksol Can you review for it? Thank you so much!!

buffalu commented 2 months ago

hey, was skimming token standards on solana + i think it makes sense to use the metaplex one as its a "centralized registry" for tokens + apps use. i think the library you're using is meant to be used with token22 metadata pointer: https://spl.solana.com/token-2022/extensions#metadata-pointer

the recommended library is the metadata library: https://github.com/metaplex-foundation/mpl-token-metadata

you can look at an example of using it here: https://github.com/solana-labs/solana-program-library/blob/48b8381f8ac272e27b9425eac6aade669da915dc/stake-pool/program/src/processor.rs#L3168

aoikurokawa commented 2 months ago

I need to modify lrt_mint to vrt_mint.

aoikurokawa commented 2 months ago

@buffalu Thank you for reviewing!!

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 78.44311% with 36 lines in your changes missing coverage. Please review.

Project coverage is 69.10%. Comparing base (6030310) to head (043928f). Report is 1 commits behind head on master.

Files Patch % Lines
vault_sdk/src/inline_mpl_token_metadata.rs 61.84% 29 Missing :warning:
vault_core/src/loader.rs 50.00% 6 Missing :warning:
vault_program/src/create_token_metadata.rs 98.07% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #32 +/- ## ========================================== + Coverage 68.54% 69.10% +0.56% ========================================== Files 85 86 +1 Lines 7067 7228 +161 ========================================== + Hits 4844 4995 +151 - Misses 2223 2233 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.