jitsi-contrib / installers

Jitsi installers for different use cases and environments
Apache License 2.0
24 stars 22 forks source link

Allow users to set their own JWT ID and Secret when setting up tokens #2

Closed MorayM closed 1 year ago

MorayM commented 1 year ago

I've been migrating our application which includes Jitsi as part of its feature set. I'm trying to replicate our previous installation and our application ID and JWT secret are used by other components which can't easily be changed. This PR allows users to specify their own APP_ID and APP_SECRET variables by setting them as environment variables before running the script, in the same manner as JITSI_HOST and TURN_HOST

MorayM commented 1 year ago

Found a small issue, is it worth adding a note to the readme explaining that if APP_SECRET contains & or \ then these need to be escaped with \ to prevent sed trying to parse them?