jitsi / docker-jitsi-meet

Jitsi Meet on Docker
https://hub.docker.com/u/jitsi/
Apache License 2.0
3.04k stars 1.35k forks source link

Suggestion: option to turn off gzip compression by ENV - to be usable behind nginx reverse proxy with sub_filter #1279

Open BananaAcid opened 2 years ago

BananaAcid commented 2 years ago

Using a nginx reverse proxy and trying to replace content with nginx sub_filter directive, GZIP must be disabled (as uncompressed streams between servers is best anyways, as the outward facing proxy handles SSL and any kind of compression, brotli etc).

Changing the /config/nginx/nginx.conf does not seem to be persistent between reboots.

Any suggestions on how to tackle this?

saghul commented 2 years ago

Adding some env vars to disable compression would be acceptable.

BananaAcid commented 2 years ago

Adding some env vars to disable compression would be acceptable.

Sounds good, as other container handle this as well - would be great to see this in the dockerfile / container.

saghul commented 2 years ago

Do you intend to send a PR? Just to be clear, I don't have the time to look into this anytime soon.

BananaAcid commented 2 years ago

I am probably not able to figure out how --

BananaAcid commented 2 years ago

temporary solution, in a docker-compose:

version: '3'

services:

    # Frontend
    web:
        image: jitsi/web:stable-7210-2

        command: >
            bash -c "
                echo \"checking for required paths / creating them\"
                mkdir -p ${CONFIG}/{web/crontabs,web/letsencrypt,transcripts,prosody/config,prosody/prosody-plugins-custom,jicofo,jvb,jigasi,jibri}

                echo \"disabling gzip compression\"
                sed -i \"s/gzip on/gzip off/g\" /config/nginx/nginx.conf

                echo \"waiting for nginx\"
                until pidof nginx >> /dev/null ;
                do
                  echo \"... waiting\"
                  sleep 1
                done

                sleep 7
                echo \"restarting nginx\"
                /etc/init.d/nginx stop
                sleep 7
                /etc/init.d/nginx start

                sleep 100000000000000;"

        volumes:
...