jitsi / docker-jitsi-meet

Jitsi Meet on Docker
https://hub.docker.com/u/jitsi/
Apache License 2.0
2.99k stars 1.34k forks source link

Wrong param for ffmpeg stable-9457 #1836

Closed SkyTaurus closed 1 day ago

SkyTaurus commented 6 days ago

I update jitsi from stable-9258 to stable-9457 from dockerhub After update JIBRI not working. jibri stable-9258 ffmpeg version 4.3.6-0+deb11u1 Copyright (c) 2000-2023 the FFmpeg developers

stable-9457 ffmpeg version 5.1.4-0+deb12u1 Copyright (c) 2000-2023 the FFmpeg developers

The environment in the new version of Jibri is different, a newer version of X, a new version of the Debian base image It seems that ffmpeg does not understand the --i argument at all for grabbing from X -f x11grab.

image

if I move the -i argument immediately after -f x11grab, I can see that ffmpeg understands this argument.

image

saghul commented 6 days ago

Damn, this will require a change in Jibri... Ping @aaronkvanmeerten have we observed this?

damencho commented 6 days ago

But if there are differences in ffmpeg, there can be any version on the server ...

emrahcom commented 6 days ago

I remember this issue. It should be related with changed xorg config. The old config is not supported by Debian Bookworm.

https://github.com/jitsi/jibri/blob/master/resources/debian-package/etc/jitsi/jibri/xorg-video-dummy.conf#L108-L113

https://github.com/jitsi/docker-jitsi-meet/blob/master/jibri/rootfs/defaults/xorg-video-dummy.conf#L113-L118

emrahcom commented 6 days ago

https://github.com/jitsi/jibri/pull/522

saghul commented 6 days ago

Oh, have we released that Jibri to stable @damencho ?

damencho commented 6 days ago

Yes, it was in stable since 10-Nov-2023 jibri_8.0-160-g5af7dd7-1_all.deb

emrahcom commented 6 days ago

But Dockerized Jibri generates its own xorg-video-dummy.conf. It doesn't use the config comes from the deb package.