search

jitsi / docker-jitsi-meet

Jitsi Meet on Docker
https://hub.docker.com/u/jitsi/
Apache License 2.0
3.09k stars 1.37k forks source link

web: remove unnecessary option #1883

Closed saghul closed 3 months ago

saghul commented 3 months ago

@damencho I see we don't use this in prod and get it from the conference request. Does it make sense to remove the option altogether from lib-jitsi-meet?

damencho commented 3 months ago

Well ... I think people who do not run https://github.com/jitsi/jitsi-meet/blob/master/resources/prosody-plugins/mod_client_proxy.lua and prosody as their XMPP server (the Openfire guys) use this setting so they can communicate with jicofo.

saghul commented 3 months ago

But this Docker, it uses prosody here, so we can assume that, can't we?

damencho commented 3 months ago

Yes, we can drop it. But in the other places we set config.hosts.focus and I do not see it here. Does it work without it?

saghul commented 3 months ago

Yep it does.