feat(transcriber): fix exposing transcript path in web

jitsi / docker-jitsi-meet

Jitsi Meet on Docker

https://hub.docker.com/u/jitsi/

Apache License 2.0

3.09k stars 1.37k forks source link

feat(transcriber): fix exposing transcript path in web #1955

Closed bmagistro closed 3 weeks ago

bmagistro commented 4 weeks ago

This addes the transcipts path to the list of static items that should be allowed by nginx.

Fixes #1427

saghul commented 3 weeks ago

Have you tested this? I don't think ti would work since the web container is not where the transcript files are stored, are they?

bmagistro commented 3 weeks ago

Very valid question as I expected it to be more complicated too. I did and have it running on a test instance right now.

Looking now at the why/how, it looks like transcripts are volume mounted in via the web compose https://github.com/jitsi/docker-jitsi-meet/blob/master/docker-compose.yml#L14C1-L15C1 . I didn't look to see why when developing this, just exec'd in and started looking around based on the logs but also knew our compose files should be pretty close to the stock ones provided.

saghul commented 3 weeks ago

Ah looks like we have them mounted here: https://github.com/jitsi/docker-jitsi-meet/blob/74d913f58acfe01573aa335ea363b8487137078d/transcriber.yml#L9

LGTM @aaronkvanmeerten any objections?