search

jitsi / handbook

The Jitsi Handbook
https://jitsi.github.io/handbook/
Apache License 2.0
186 stars 460 forks source link

Update android-sdk.md #404

Closed NilabhB closed 1 year ago

NilabhB commented 1 year ago

When allprojects{} is missing in build.gradle, set the maven repository in settings.gradle.

saghul commented 1 year ago

Even if the section is missing it can be added, can't it?

NilabhB commented 1 year ago

Hi,

I tried all possibilities, without implementing it on settings.gradle the gradle building is not successful. Currently in newer projects gradle.build contains only the plugins{}. Even if we manually drop the block of codes there, it will through some error. I overcome it by replacing it on settings.gradle.

Either way allprojects{} seems to be obsolete now, so I thought of updating it.

saghul commented 1 year ago

What Gradle version obsoletes it? We should have both and mention which Gradle version requires the new syntax, since not everyone will be running the new version day one.

NilabhB commented 1 year ago

Yes, you are right. I am not sure from which gradle version allprojects{} is removed but I can say that gradle version 7.4 doesn't have the allprojects{}. Previous versions of gradle (eg. 6.7.1) use to have allprojects{}. Now in gradle version 7.4 build.gradle consists of only the plugins{} by default (checked by creating a new project).

As you have said, not everyone will start from day one, if they find the allprojects{} in the build.gradle they will follow the old process only, in case they can't find it then they will implement it in settings.gradle, this is what I requested for merging. I haven't removed the old conventional process from the handbook, just added the alternatives for newer versions.