jitsi / handbook

The Jitsi Handbook
https://jitsi.github.io/handbook/
Apache License 2.0
186 stars 460 forks source link

Hide hash links in the Jitsi Meet Handbook #517

Closed amedinaaa closed 1 month ago

amedinaaa commented 1 month ago

What happened?

Adding in the issue reporting template:

Provide Detailed Information: Only pertains to the handbook.

Description of the Issue: It looks like several pages of the handbook contain hash links to specific references to subsections within the handbook. The links in themselves are perfectly fine but is it possible we can further hide the "hashes" instead of just setting the opacity to zero? I'm thinking of maybe adding a "display: none" to the "hash-link" class.

Screenshot:

Screenshot 2024-07-24 at 7 46 32 PM

Reproduction Steps:

  1. Go to the handbook: https://jitsi.github.io/handbook/
  2. Select any relevant handbook page
  3. Hover over a subsection title

Expected Behavior: We should ideally completely hide these hash links to readers.

Actual Behavior: "Hashes" are apparent when hovering over subsection titles.

Platform

Browser / app / sdk version

Chrome Version: 126.0.6478.127

Relevant log output

No response

Reproducibility

More details?

No response

shawnchin commented 1 month ago

Why hide them? I actually find them really useful went I want to copy links to specific sections.

amedinaaa commented 1 month ago

If those hashes are solely for copying links for specific sections, I think a copy icon or perhaps the word "copy" might be a lot more intuitive for users/readers looking to share a link.

saghul commented 1 month ago

Exactly what @shawnchin says. They are meant to be able to copy the links.