search

jitsi / ice4j

A Java implementation of the ICE protocol
Apache License 2.0
437 stars 232 forks source link

fix: Add a null check. #253

Closed bgrozev closed 2 years ago

bgrozev commented 2 years ago

org.ice4j.stack.StunClientTransaction$Retransmitter.run: A client tran retransmission failed java.lang.NullPointerException at org.ice4j.stack.Connector.sendMessage(Connector.java:329) at org.ice4j.stack.NetAccessManager.sendMessage(NetAccessManager.java:635)

codecov[bot] commented 2 years ago

Codecov Report

Merging #253 (c48dee5) into master (a9ba80e) will decrease coverage by 0.31%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #253      +/-   ##
============================================
- Coverage     39.14%   38.82%   -0.32%     
+ Complexity     1378     1366      -12     
============================================
  Files           178      178              
  Lines         12164    12167       +3     
  Branches       1842     1843       +1     
============================================
- Hits           4761     4724      -37     
- Misses         6742     6781      +39     
- Partials        661      662       +1
Impacted Files Coverage Δ
src/main/java/org/ice4j/stack/Connector.java 59.52% <50.00%> (-0.98%) :arrow_down:
...in/java/org/ice4j/stack/MessageProcessingTask.java 62.00% <0.00%> (-8.00%) :arrow_down:
...n/java/org/ice4j/socket/MergingDatagramSocket.java 31.63% <0.00%> (-5.11%) :arrow_down:
...in/java/org/ice4j/ice/ConnectivityCheckServer.java 71.66% <0.00%> (-3.34%) :arrow_down:
...rc/main/java/org/ice4j/stack/NetAccessManager.java 60.13% <0.00%> (-2.10%) :arrow_down:
...in/java/org/ice4j/stack/StunClientTransaction.java 79.61% <0.00%> (-1.95%) :arrow_down:
src/main/java/org/ice4j/ice/CandidatePair.java 69.40% <0.00%> (-0.75%) :arrow_down:
src/main/java/org/ice4j/stack/StunStack.java 52.76% <0.00%> (-0.70%) :arrow_down:
src/main/java/org/ice4j/ice/Agent.java 54.61% <0.00%> (-0.64%) :arrow_down:
...org/ice4j/socket/MultiplexingXXXSocketSupport.java 51.51% <0.00%> (-0.61%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9ba80e...c48dee5. Read the comment docs.