jitsi / ice4j

A Java implementation of the ICE protocol
Apache License 2.0
437 stars 233 forks source link

fix: Fix creating STUN harvesters when no local addresses are allowed. #265

Closed bgrozev closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #265 (43fecc2) into master (28a23e1) will increase coverage by 0.11%. The diff coverage is 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/jitsi/ice4j/pull/265/graphs/tree.svg?width=650&height=150&src=pr&token=0f9IrT1MS2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi)](https://codecov.io/gh/jitsi/ice4j/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) ```diff @@ Coverage Diff @@ ## master #265 +/- ## ============================================ + Coverage 38.91% 39.02% +0.11% Complexity 1374 1374 ============================================ Files 178 178 Lines 12244 12247 +3 Branches 1871 1872 +1 ============================================ + Hits 4765 4780 +15 + Misses 6831 6811 -20 - Partials 648 656 +8 ``` | [Impacted Files](https://codecov.io/gh/jitsi/ice4j/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) | Coverage Δ | | |---|---|---| | [.../ice4j/ice/harvest/MappingCandidateHarvesters.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovaWNlL2hhcnZlc3QvTWFwcGluZ0NhbmRpZGF0ZUhhcnZlc3RlcnMuamF2YQ==) | `26.85% <0.00%> (-0.77%)` | :arrow_down: | | [...in/java/org/ice4j/stack/MessageProcessingTask.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovc3RhY2svTWVzc2FnZVByb2Nlc3NpbmdUYXNrLmphdmE=) | `62.00% <0.00%> (-8.00%)` | :arrow_down: | | [src/main/java/org/ice4j/util/PeriodicRunnable.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovdXRpbC9QZXJpb2RpY1J1bm5hYmxlLmphdmE=) | `74.24% <0.00%> (-1.52%)` | :arrow_down: | | [...in/java/org/ice4j/ice/ConnectivityCheckClient.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovaWNlL0Nvbm5lY3Rpdml0eUNoZWNrQ2xpZW50LmphdmE=) | `54.46% <0.00%> (-0.60%)` | :arrow_down: | | [.../java/org/ice4j/pseudotcp/PseudoTcpSocketImpl.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovcHNldWRvdGNwL1BzZXVkb1RjcFNvY2tldEltcGwuamF2YQ==) | `65.41% <0.00%> (-0.58%)` | :arrow_down: | | [...c/main/java/org/ice4j/pseudotcp/PseudoTCPBase.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovcHNldWRvdGNwL1BzZXVkb1RDUEJhc2UuamF2YQ==) | `64.00% <0.00%> (-0.47%)` | :arrow_down: | | [...rc/main/java/org/ice4j/stack/NetAccessManager.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovc3RhY2svTmV0QWNjZXNzTWFuYWdlci5qYXZh) | `62.00% <0.00%> (ø)` | | | [src/main/java/org/ice4j/ice/Agent.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovaWNlL0FnZW50LmphdmE=) | `54.84% <0.00%> (+0.31%)` | :arrow_up: | | [src/main/java/org/ice4j/ice/CheckList.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovaWNlL0NoZWNrTGlzdC5qYXZh) | `57.83% <0.00%> (+0.60%)` | :arrow_up: | | [src/main/java/org/ice4j/ice/CandidatePair.java](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaWNlNGovaWNlL0NhbmRpZGF0ZVBhaXIuamF2YQ==) | `70.14% <0.00%> (+0.74%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/jitsi/ice4j/pull/265/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/jitsi/ice4j/pull/265?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/jitsi/ice4j/pull/265?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Last update [28a23e1...43fecc2](https://codecov.io/gh/jitsi/ice4j/pull/265?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi).