search

jitsi / ice4j

A Java implementation of the ICE protocol
Apache License 2.0
437 stars 232 forks source link

ref(NetworkUtils): Remove unused utils. #279

Closed bgrozev closed 6 months ago

bgrozev commented 6 months ago

These utilities are no longer used by jitsi desktop or any other jitsi project I could find, so imo they are not worth maintaining in ice4j:

boolean isValidIPAddress(String address)
boolean isIPv4Address(String address)
boolean isIPv6Address(String address)
byte[] strToIPv4(String ipv4AddrStr)
byte[] strToIPv6(String ipv6AddrStr)
byte[] mappedIPv4ToRealIPv4(byte[] addr)

There are readily available alternatives in e.g. Guava's InetAddresses:

boolean isInetAddress(String ipString)
byte[] ipStringToBytes(String ipStringParam)
Inet4Address getEmbeddedIPv4ClientAddress(Inet6Address ip)