search

jitsi / ice4j

A Java implementation of the ICE protocol
Apache License 2.0
437 stars 232 forks source link

Agent should failed on SocketNotFoundException #280 #281

Closed Horcrux7 closed 2 months ago

Horcrux7 commented 6 months ago

If there are no matching candidate because a configuration mistake then the agent should failed.

jitsi-jenkins commented 6 months ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

bgrozev commented 6 months ago

Jenkins please test this

damencho commented 6 months ago

Jenkins test this please

Horcrux7 commented 6 months ago

@jitsi-jenkins I sign CLA now.

Horcrux7 commented 5 months ago

Do you have receive the CLA? Or do you need other information to continue with this PR?

bgrozev commented 5 months ago

Confirmed the CLA, thanks. I need to understand the change and make sure it doesn't break other cases, and I haven't had the time to do it yet. I'll try to get to it this week.

anormal81 commented 4 months ago

Any update on when this pull request will be merged? We ran into the same problem.

gamma commented 2 months ago

Hi, can someone please review this PR?

Horcrux7 commented 2 months ago

You are right. A listener should call ever outside of a synchronized.

JonathanLennox commented 2 months ago

Jenkins test this please