Closed dsmeytis closed 22 hours ago
Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.
already signed
Thanks for the contribution! I left a couple of minor requests. I'll run a manual test and let you know if I have more.
Confirmed CLA. Jenkins, please add to whitelist
Looks good after testing
hi @bgrozev, thanks for the review! Actually for my deployment I ended up with the java.net.http.HttpClient
implementation. If you wish I can push updated solution, otherwise I'll address your requests and we'll proceed with it.
Sure, unless it's a large change let's go with HttpClient
@bgrozev please take a look at https://github.com/jitsi/ice4j/pull/297
Hello, AWS recommend to disable IMDSv1 support for EC2 instances: https://aws.amazon.com/blogs/security/get-the-full-benefits-of-imdsv2-and-disable-imdsv1-across-your-aws-infrastructure/ However it breaks AwsCandidateHarvester functionality because REST endpoints it uses to detect EC2 and obtain private/public IPs become unavailable. I would like to propose the fix that will work for both IMDSv1 and IMDSv2:
doTestEc2()
will now try to obtain an API token asEC2_TEST_URL
is unavailable without a token.fetch()
to set a method and pass required headers.