search

jitsi / jibri

Jitsi BRoadcasting Infrastructure
Apache License 2.0
607 stars 313 forks source link

fix: get the internal-api-port from jibri.conf if exists (hocon) #446

Closed emrahcom closed 2 years ago

emrahcom commented 2 years ago

issue #444

Allow to use the customized internal-api-port in jibri tools if internal-api-port is customized in jibri.conf. This PR requires the ruby-hocon package as a jibri dependency.

jitsi-jenkins commented 2 years ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

codecov[bot] commented 2 years ago

Codecov Report

Merging #446 (b49afff) into master (5f53fd5) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #446   +/-   ##
=========================================
  Coverage     47.42%   47.42%           
  Complexity      173      173           
=========================================
  Files            71       71           
  Lines          1887     1887           
  Branches        186      186           
=========================================
  Hits            895      895           
  Misses          927      927           
  Partials         65       65

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f53fd5...b49afff. Read the comment docs.