jitsi / jibri

Jitsi BRoadcasting Infrastructure
Apache License 2.0
607 stars 313 forks source link

feat: Update Jetty to Jetty 11 and ktor to ktor-2.0.2-jitsi #482

Closed JonathanLennox closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #482 (4241349) into master (8f198ae) will decrease coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #482      +/-   ##
============================================
- Coverage     47.85%   47.85%   -0.01%     
  Complexity      174      174              
============================================
  Files            73       73              
  Lines          2096     2094       -2     
  Branches        199      199              
============================================
- Hits           1003     1002       -1     
+ Misses         1023     1022       -1     
  Partials         70       70              
Impacted Files Coverage Δ
src/main/kotlin/org/jitsi/jibri/Main.kt 0.00% <ø> (ø)
...rc/main/kotlin/org/jitsi/jibri/api/http/HttpApi.kt 40.00% <ø> (ø)
...bri/selenium/status_checks/EmptyCallStatusCheck.kt 94.73% <0.00%> (-0.27%) :arrow_down:
...n/org/jitsi/jibri/selenium/pageobjects/CallPage.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f198ae...4241349. Read the comment docs.

JonathanLennox commented 2 years ago

Note: I've asked @oanaianc to test whether the webhooks still work after this change - I'm concerned they won't, because the ktor-server-jetty package references jetty 9.x. Please don't merge this until that test is complete.

JonathanLennox commented 2 years ago

Note: this now needs the ktor from my PR at https://github.com/ktorio/ktor/pull/3015.

JonathanLennox commented 2 years ago

Note this is now on top of https://github.com/jitsi/jibri/pull/483.

JonathanLennox commented 2 years ago

lgtm. wish i remembered what jersey was used for...part of me wonders if that dep might be obsolete.

Actually it looks like the jersey.version variable isn't referenced anywhere, so I can remove it.