fix: Authorization header sending for webhooks

cristianbotiza commented 1 year ago

the issue was caused by io.jsonwebtoken having a hardcoded call to javax.xml.bind.* packages; these are gone in java 9+. The fix was to simply upgrade the jsonwebtoken library. Use latest, 0.11.5. This also requires a split (api vs impl vs jackson), so add the API as compile dependency and the impl and jackson serializer as runtime dependencies
add logging around RefreshingProperty throwing exceptions
separate Throwable (unrecoverable, propagate it) vs Exception (return null, rely on next refresh, but log)
update unit tests
use bearerAuth() instead of header(), to reduce verbosity

jitsi-jenkins commented 1 year ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

saghul commented 1 year ago

1 check was pending 🔥

raluca8x8 commented 1 year ago

1 check was pending 🔥

Did not see that, I will keep an eye on the result then

cristianbotiza commented 1 year ago

what check, Saul?

jitsi / jibri

fix: Authorization header sending for webhooks #493