search

jitsi / jibri

Jitsi BRoadcasting Infrastructure
Apache License 2.0
600 stars 314 forks source link

jibri debian package depends on icewm #526

Closed 532910 closed 7 months ago

532910 commented 9 months ago

I believe it must not.

% apt show jibri
Package: jibri
Version: 8.0-145-g1a4bb8e-1
Priority: optional
Section: net
Maintainer: dev@jitsi.org
Installed-Size: 40.0 MB
Depends: default-jre-headless | java8-runtime-headless | java8-runtime, ffmpeg, curl, alsa-utils, icewm, xdotool, xserver-xorg-video-dummy, procps, ruby-hocon
Download-Size: 35.4 MB
APT-Manual-Installed: yes
APT-Sources: https://download.jitsi.org stable/ Packages
Description: Jibri
 Jibri can be used to capture data from a Jitsi Meet conference and record it to a file or stream it to a url

N: There are 16 additional records. Please use the '-a' switch to see them.
% apt policy jibri 
jibri:
  Installed: 8.0-145-g1a4bb8e-1
  Candidate: 8.0-145-g1a4bb8e-1
  Version table:
 *** 8.0-145-g1a4bb8e-1 500
        500 https://download.jitsi.org stable/ Packages
        100 /var/lib/dpkg/status
     8.0-140-gccc7278-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-139-g7ab9aa2-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-137-g260cee3-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-121-g27323fe-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-116-gca0c772-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-114-g20e233e-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-113-g56bf495-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-105-gddca7a2-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-104-g9871ba1-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-93-g51fe7a2-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-83-g204354d-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-61-g99288dc-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-53-ga574be9-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-34-gd133175-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-14-g0ccc3f6-1 500
        500 https://download.jitsi.org stable/ Packages
     8.0-0-ge9fa56a-1 500
        500 https://download.jitsi.org stable/ Packages
532910 commented 9 months ago

the same as xdotool

saghul commented 9 months ago

Jibri starts Chrome in a window manager (I'm not sure it will behave well otherwise) and icewm is a sensible option. What problem do you have with it?

532910 commented 7 months ago

Sorry for late response ): No problem, but why this couldn't be done without icewm?

Moreover, as I see xdotool is not used: it was added in https://github.com/jitsi/jibri/commit/de96c0ac263c5937dd2200a7c544048cac092efe and removed in https://github.com/jitsi/jibri/commit/0907e0384072ba3deab18370ac50f85aa0197e56

532910 commented 7 months ago

https://github.com/jitsi/jibri/pull/531

saghul commented 7 months ago

It might be possible to skip icewm, but at this point the risk of having problems because of that is way higher than the reward, since it consumes virtually nothing.

532910 commented 7 months ago

Agree. Possible this should be reworked with wayland, when it become working and stable enough?

saghul commented 7 months ago

Surely Wayland would a large enough change that will warrant re-evaluating that.