jitsi / jicofo

JItsi COnference FOcus is a server side focus component used in Jitsi Meet conferences.
Apache License 2.0
314 stars 350 forks source link

fix: Do not leave the conference soon after a conference-request. #1119

Closed bgrozev closed 9 months ago

bgrozev commented 9 months ago

Fixes a race condition in which the conference was stopped while a client was in the process of joining.

codecov[bot] commented 9 months ago

Codecov Report

Merging #1119 (d95d74b) into master (067e575) will increase coverage by 0.01%. The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1119      +/-   ##
============================================
+ Coverage     27.86%   27.88%   +0.01%     
- Complexity      473      474       +1     
============================================
  Files           128      128              
  Lines          7783     7792       +9     
  Branches       1064     1066       +2     
============================================
+ Hits           2169     2173       +4     
- Misses         5342     5346       +4     
- Partials        272      273       +1     
Files Coverage Δ
...otlin/org/jitsi/jicofo/xmpp/ConferenceIqHandler.kt 53.53% <100.00%> (+0.47%) :arrow_up:
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 44.65% <55.55%> (-0.07%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 067e575...d95d74b. Read the comment docs.

bgrozev commented 9 months ago

Jicofo needs to leave the room when the last occupant leaves, otherwise "end conference" can not be enforced. We'll address the issue with a client reload instead