search

jitsi / jicofo

JItsi COnference FOcus is a server side focus component used in Jitsi Meet conferences.
Apache License 2.0
314 stars 350 forks source link

fix: Fix NPE when a conference request has no payload #1126

Closed bgrozev closed 6 months ago

bgrozev commented 6 months ago

Jetty doesn't recognize that the kotlin param can't be null which results in a NPE and response 500. Return 400 without polluting the logs instead.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (660d705) 27.64% compared to head (0682a6c) 28.93%. Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/jitsi/jicofo/pull/1126/graphs/tree.svg?width=650&height=150&src=pr&token=wdwr26KPKY&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi)](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) ```diff @@ Coverage Diff @@ ## master #1126 +/- ## ============================================ + Coverage 27.64% 28.93% +1.29% - Complexity 468 475 +7 ============================================ Files 128 128 Lines 7800 7818 +18 Branches 1066 1069 +3 ============================================ + Hits 2156 2262 +106 + Misses 5373 5284 -89 - Partials 271 272 +1 ``` | [Files](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) | Coverage Δ | | |---|---|---| | [.../main/kotlin/org/jitsi/jicofo/xmpp/muc/ChatRoom.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvLWNvbW1vbi9zcmMvbWFpbi9rb3RsaW4vb3JnL2ppdHNpL2ppY29mby94bXBwL211Yy9DaGF0Um9vbS5rdA==) | `0.00% <ø> (ø)` | | | [...ofo/src/main/kotlin/org/jitsi/jicofo/xmpp/Smack.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2tvdGxpbi9vcmcvaml0c2kvamljb2ZvL3htcHAvU21hY2sua3Q=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [.../kotlin/org/jitsi/jicofo/rest/ConferenceRequest.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2tvdGxpbi9vcmcvaml0c2kvamljb2ZvL3Jlc3QvQ29uZmVyZW5jZVJlcXVlc3Qua3Q=) | `0.00% <0.00%> (ø)` | | | [...tsi/jicofo/conference/JitsiMeetConferenceImpl.java](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2phdmEvb3JnL2ppdHNpL2ppY29mby9jb25mZXJlbmNlL0ppdHNpTWVldENvbmZlcmVuY2VJbXBsLmphdmE=) | `44.40% <0.00%> (+1.09%)` | :arrow_up: | | [...n/kotlin/org/jitsi/jicofo/xmpp/muc/ChatRoomImpl.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvLWNvbW1vbi9zcmMvbWFpbi9rb3RsaW4vb3JnL2ppdHNpL2ppY29mby94bXBwL211Yy9DaGF0Um9vbUltcGwua3Q=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jitsi/jicofo/pull/1126/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Last update [ed9df12...0682a6c](https://app.codecov.io/gh/jitsi/jicofo/pull/1126?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi).